diff --git a/formatter.nix b/formatter.nix index cb4eb0d7..28b3de2b 100644 --- a/formatter.nix +++ b/formatter.nix @@ -21,7 +21,7 @@ treefmt.programs.mypy.enable = true; treefmt.programs.mypy.directories = { - "pkgs/clan-cli".extraPythonPackages = self'.packages.clan-cli-unwrapped.pytestDependencies; + "pkgs/clan-cli".extraPythonPackages = self'.packages.clan-cli.pytestDependencies; }; treefmt.settings.formatter.nix = { diff --git a/pkgs/clan-cli/default.nix b/pkgs/clan-cli/default.nix index e252e3c6..35aec8e8 100644 --- a/pkgs/clan-cli/default.nix +++ b/pkgs/clan-cli/default.nix @@ -152,6 +152,11 @@ python3.pkgs.buildPythonApplication { installShellCompletion --fish --name clan.fish \ <(${argcomplete}/bin/register-python-argcomplete --shell fish clan) ''; + # Don't leak python packages into a devshell. + # It can be very confusing if you `nix run` than load the cli from the devshell instead. + postFixup = '' + rm $out/nix-support/propagated-build-inputs + ''; checkPhase = '' PYTHONPATH= $out/bin/clan --help if grep --include \*.py -Rq "breakpoint()" $out; then diff --git a/pkgs/clan-cli/flake-module.nix b/pkgs/clan-cli/flake-module.nix index 3a657e91..2f912d0a 100644 --- a/pkgs/clan-cli/flake-module.nix +++ b/pkgs/clan-cli/flake-module.nix @@ -2,24 +2,18 @@ { perSystem = { self', pkgs, ... }: { devShells.clan-cli = pkgs.callPackage ./shell.nix { - inherit (self'.packages) clan-cli-unwrapped ui-assets nix-unit; + inherit (self'.packages) clan-cli ui-assets nix-unit; }; packages = { - clan-cli-unwrapped = pkgs.python3.pkgs.callPackage ./default.nix { + clan-cli = pkgs.python3.pkgs.callPackage ./default.nix { inherit (self'.packages) ui-assets; inherit (inputs) nixpkgs; }; - # Don't leak python packages into a devshell. - # It can be very confusing if you `nix run` than than load the cli from the devshell instead. - clan-cli = pkgs.runCommand "clan" { } '' - mkdir $out - ln -s ${self'.packages.clan-cli-unwrapped}/bin $out - ''; - inherit (self'.packages.clan-cli-unwrapped) clan-openapi; + inherit (self'.packages.clan-cli) clan-openapi; default = self'.packages.clan-cli; }; - checks = self'.packages.clan-cli-unwrapped.tests; + checks = self'.packages.clan-cli.tests; }; } diff --git a/pkgs/clan-cli/shell.nix b/pkgs/clan-cli/shell.nix index b05612bd..6d53c9c9 100644 --- a/pkgs/clan-cli/shell.nix +++ b/pkgs/clan-cli/shell.nix @@ -1,4 +1,4 @@ -{ nix-unit, clan-cli-unwrapped, ui-assets, system, mkShell, writeScriptBin, openssh }: +{ nix-unit, clan-cli, ui-assets, system, mkShell, writeScriptBin, openssh }: let checkScript = writeScriptBin "check" '' nix build .#checks.${system}.{treefmt,clan-pytest} -L "$@" @@ -8,14 +8,14 @@ mkShell { packages = [ nix-unit openssh - clan-cli-unwrapped.checkPython + clan-cli.checkPython ]; shellHook = '' tmp_path=$(realpath ./.direnv) rm -f clan_cli/nixpkgs clan_cli/webui/assets - ln -sf ${clan-cli-unwrapped.nixpkgs} clan_cli/nixpkgs + ln -sf ${clan-cli.nixpkgs} clan_cli/nixpkgs ln -sf ${ui-assets} clan_cli/webui/assets export PATH="$tmp_path/bin:${checkScript}/bin:$PATH"