From f885c877bc579b73991e4b51b1d5fb467b77f245 Mon Sep 17 00:00:00 2001 From: DavHau Date: Thu, 5 Oct 2023 17:33:38 +0200 Subject: [PATCH] clan-cli: improve debug logging --- pkgs/clan-cli/clan_cli/__init__.py | 8 ++------ pkgs/clan-cli/clan_cli/join/__init__.py | 2 +- pkgs/clan-cli/clan_cli/task_manager.py | 4 ++-- pkgs/clan-cli/default.nix | 2 +- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/pkgs/clan-cli/clan_cli/__init__.py b/pkgs/clan-cli/clan_cli/__init__.py index 432e041d..5e26886d 100644 --- a/pkgs/clan-cli/clan_cli/__init__.py +++ b/pkgs/clan-cli/clan_cli/__init__.py @@ -4,7 +4,6 @@ from types import ModuleType from typing import Optional from . import config, create, join, machines, secrets, vms, webui -from .errors import ClanError from .ssh import cli as ssh_cli argcomplete: Optional[ModuleType] = None @@ -68,11 +67,8 @@ def main() -> None: if not hasattr(args, "func"): return - try: - args.func(args) - except ClanError as e: - print(e, file=sys.stderr) - sys.exit(1) + + args.func(args) if __name__ == "__main__": diff --git a/pkgs/clan-cli/clan_cli/join/__init__.py b/pkgs/clan-cli/clan_cli/join/__init__.py index 7b96d085..6b1344ed 100644 --- a/pkgs/clan-cli/clan_cli/join/__init__.py +++ b/pkgs/clan-cli/clan_cli/join/__init__.py @@ -9,7 +9,7 @@ def join(args: argparse.Namespace) -> None: # start webui in background uri = args.flake_uri.removeprefix("clan://") subprocess.run( - ["clan", "webui", f"/join?flake={urllib.parse.quote_plus(uri)}"], + ["clan", "--debug", "webui", f"/join?flake={urllib.parse.quote_plus(uri)}"], # stdout=sys.stdout, # stderr=sys.stderr, ) diff --git a/pkgs/clan-cli/clan_cli/task_manager.py b/pkgs/clan-cli/clan_cli/task_manager.py index 03f1569e..65c03dba 100644 --- a/pkgs/clan-cli/clan_cli/task_manager.py +++ b/pkgs/clan-cli/clan_cli/task_manager.py @@ -51,10 +51,10 @@ class Command: try: for line in fd: if fd == self.p.stderr: - self.log.debug(f"[{cmd[0]}] stderr: {line}") + print(f"[{cmd[0]}] stderr: {line}") self.stderr.append(line) else: - self.log.debug(f"[{cmd[0]}] stdout: {line}") + print(f"[{cmd[0]}] stdout: {line}") self.stdout.append(line) self._output.put(line) except BlockingIOError: diff --git a/pkgs/clan-cli/default.nix b/pkgs/clan-cli/default.nix index 283f547e..8c4ca0a3 100644 --- a/pkgs/clan-cli/default.nix +++ b/pkgs/clan-cli/default.nix @@ -177,7 +177,7 @@ python3.pkgs.buildPythonApplication { desktopItems = [ (makeDesktopItem { name = "clan"; - exec = "clan join %u"; + exec = "clan --debug join %u"; desktopName = "CLan Manager"; startupWMClass = "clan"; mimeTypes = [ "x-scheme-handler/clan" ];