exports: reject a colon anywhere in a scope part #8085

Merged
hsjobeki merged 1 commits from fix/exports-scope-colon-guard into main 2026-10-22 10:27:58 +00:00
Member

builtins.match ".?:.?" is anchored and .? matches one character, so
the guard only fires for parts of three characters or less. "foo:bar"
passes here and fails later in parseScope.

Description of the change

Checklist

  • Ensured documentation is up to date
  • Added tests for all bug fixes and features
  • Doesn't affect backwards compatibility - or check the next points
    • Added the breaking change and migration details to docs/release-notes.md
    • !!! Review from another person is required BEFORE merge !!!

New major features

  • Added major features
    • All features are mentioned in docs/release-notes.md
    • All features are tested sufficiently via:
      • eval tests (for NixOS modules and nix functions)
      • python tests for python API and CLI code
      • VM or container tests for new clan services
`builtins.match ".?:.?"` is anchored and `.?` matches one character, so the guard only fires for parts of three characters or less. "foo:bar" passes here and fails later in parseScope. ## Description of the change <!-- Brief summary of the change if not already clear from the title --> ## Checklist - [ ] Ensured documentation is up to date - [ ] Added tests for all bug fixes and features - [ ] Doesn't affect backwards compatibility - or check the next points - [ ] Added the breaking change and migration details to docs/release-notes.md - !!! Review from another person is required *BEFORE* merge !!! ## New major features - [ ] Added major features - [ ] All features are mentioned in docs/release-notes.md - [ ] All features are tested sufficiently via: - [ ] eval tests (for NixOS modules and nix functions) - [ ] python tests for python API and CLI code - [ ] VM or container tests for new clan services
hsjobeki added 1 commit 2026-09-15 14:25:08 +00:00
exports: reject a colon anywhere in a scope part
PR Size Review Check / pr-size-review-gate (pull_request) Successful in 14s
sizelint on each commit / sizelint (pull_request) Successful in 18s
buildbot/nix-eval evaluation succeeded in 1m 13s (3 warnings)
label-pr / external (pull_request_target) Successful in 6m26s
buildbot/nix-build 150 attributes built
gitea-mq/buildbot/nix-eval evaluation succeeded in 2m 4s (1 warning)
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.x86_64-linux.borgbackup Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.all-packages Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.monitoring Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-darwin.all-packages Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.machine-id Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.service-dummy-test Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.dm-dns Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.mycelium Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.p2p-ssh-iroh Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-darwin.devShell-clan-site Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.hello-service Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.x86_64-linux.garage Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.admin Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.dyndns Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.state-version Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.matrix-synapse Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-darwin.eval-tests Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.x86_64-linux.monitoring Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.clan-test-iso Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.zerotier-multi-instance Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.postgresql Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.clan-site-lint Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.certificates Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.x86_64-linux.dyndns Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.clan-pytest-with-core Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.x86_64-linux.packages Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.users Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.garage Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-darwin.clan-pytest-with-core Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.data-mesher Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.wifi Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.borgbackup Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.x86_64-linux.admin Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.kde Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.devShell-clan-site Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.service-dummy-test-from-flake Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.devShell-docs Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.sshd Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.x86_64-linux.matrix-synapse Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.sshd-no-ca Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.syncthing-service Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.localbackup Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.nixos-test-password-store-mounts Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.x86_64-linux.service-dummy-test Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.x86_64-linux.ncps Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-darwin.treefmt Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build gitea:clan/clan-core#checks.aarch64-linux.pki Merge queue stopped waiting for this check
gitea-mq/buildbot/nix-build 150 attributes built
gitea-mq Merge queue passed
ff8d78ea06
`builtins.match ".?:.?"` is anchored and `.?` matches one character, so
the guard only fires for parts of three characters or less. "foo:bar"
passes here and fails later in parseScope.
hsjobeki scheduled this pull request to auto merge when all checks succeed 2026-10-08 12:11:18 +00:00
gitea-mq canceled auto merging this pull request when all checks succeed 2026-10-08 13:03:24 +00:00
First-time contributor

❌ Removed from merge queue: Check failed: buildbot/nix-build

❌ Removed from merge queue: Check failed: [buildbot/nix-build](https://nixbot.clan.lol/repos/gitea/clan/clan-core/builds/923)
First-time contributor

❌ Removed from merge queue: Check failed: buildbot/nix-build

❌ Removed from merge queue: Check failed: [buildbot/nix-build](https://nixbot.clan.lol/repos/gitea/clan/clan-core/builds/923)
hsjobeki scheduled this pull request to auto merge when all checks succeed 2026-10-22 09:52:44 +00:00
gitea-mq added the
mq
testing
label 2026-10-22 09:58:15 +00:00
hsjobeki merged commit a566329bbc into main 2026-10-22 10:27:58 +00:00
hsjobeki deleted branch fix/exports-scope-colon-guard 2026-10-22 10:27:58 +00:00
gitea-mq removed the
mq
testing
label 2026-10-22 10:28:00 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: clan/clan-core#8085