DavHau/clan-core
1
0
Fork 0
forked from clan/clan-core
Code Pull Requests Activity

don't catch all exceptions when generating facts

Browse Source
This commit is contained in:
Jörg Thalheim 2024-07-03 17:15:12 +02:00
parent 5b606c035f
commit c44a99e304
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkgs/clan-cli/clan_cli/facts/generate.py
View File

@ -208,13 +208,14 @@ def generate_facts(
was_regenerated |= _generate_facts_for_machine( was_regenerated |= _generate_facts_for_machine(
machine, service, regenerate, tmpdir, prompt machine, service, regenerate, tmpdir, prompt
) )
except Exception as exc: except (OSError, ClanError) as exc:
log.error(f"Failed to generate facts for {machine.name}: {exc}") log.error(f"Failed to generate facts for {machine.name}: {exc}")
errors += 1 errors += 1
if errors > 0: if errors > 0:
raise ClanError( msg = (
f"Failed to generate facts for {errors} hosts. Check the logs above" f"Failed to generate facts for {errors} hosts. Check the logs above"
) )
raise ClanError(msg)
if not was_regenerated: if not was_regenerated:
print("All secrets and facts are already up to date") print("All secrets and facts are already up to date")