add Vale for prose linting #1370

Merged

Qubasa merged 3 commits from fricklerhandwerk/clan-core:add-vale into main 2024-06-29 09:08:49 +00:00

Conversation 3 Commits 3 Files Changed 2 +54 -6

fricklerhandwerk commented 2024-05-15 16:37:28 +00:00

Collaborator

Copy Link

No description provided.

👍 1

fricklerhandwerk added 2 commits 2024-05-15 16:37:28 +00:00

add pre-commit check ... 6bfc6c977a

make sure things are sane before they hit CI.
this re-purposes the existing treefmt configuration.

add Vale for prose linting dc316ebfff

fricklerhandwerk requested review from Qubasa 2024-05-15 16:37:40 +00:00

fricklerhandwerk requested review from hsjobeki 2024-05-15 16:37:40 +00:00

fricklerhandwerk force-pushed add-vale from dc316ebfff to 30bdd26501 2024-05-15 18:59:05 +00:00 Compare

Qubasa commented 2024-05-17 12:58:02 +00:00

Owner

Copy Link

The vale linter itself looks interesting! If you remove the pre-commit check I would like to add it. We initially had pre-commit checks but found it to break programs like lazygit and be generally too slow. Sometimes you just want to commit a partial unfinished result :-)

The vale linter itself looks interesting! If you remove the pre-commit check I would like to add it. We initially had pre-commit checks but found it to break programs like lazygit and be generally too slow. Sometimes you just want to commit a partial unfinished result :-)

👍 1

fricklerhandwerk force-pushed add-vale from 30bdd26501 to 5dcbd6e225 2024-05-22 09:42:55 +00:00 Compare

fricklerhandwerk force-pushed add-vale from 5dcbd6e225 to d193c5de29 2024-05-22 11:13:06 +00:00 Compare

Mic92 commented 2024-05-27 13:46:50 +00:00

Owner

Copy Link

The vale linter itself looks interesting! If you remove the pre-commit check I would like to add it. We initially had pre-commit checks but found it to break programs like lazygit and be generally too slow. Sometimes you just want to commit a partial unfinished result :-)

The pre-commit hook is now optional and no longer enabled by default.

> The vale linter itself looks interesting! If you remove the pre-commit check I would like to add it. We initially had pre-commit checks but found it to break programs like lazygit and be generally too slow. Sometimes you just want to commit a partial unfinished result :-) > The pre-commit hook is now optional and no longer enabled by default.

fricklerhandwerk force-pushed add-vale from d193c5de29 to c0d3047d5a 2024-05-30 07:54:57 +00:00 Compare

fricklerhandwerk force-pushed add-vale from c0d3047d5a to 36cadcb4d3 2024-05-30 07:59:14 +00:00 Compare

Mic92 added 1 commit 2024-06-10 13:59:58 +00:00

Merge branch 'main' into add-vale 05335122ae

kenji commented 2024-06-10 14:48:27 +00:00

Owner

Copy Link

What is the status of this @fricklerhandwerk are you still working on the vale configuration?

I think it has the potential to bring value, but since it excludes so much it is hard to get a good feeling for it.

What is the status of this @fricklerhandwerk are you still working on the vale configuration? I think it has the potential to bring value, but since it excludes so much it is hard to get a good feeling for it.

Qubasa merged commit 05380828c6 into main 2024-06-29 09:08:49 +00:00

Qubasa referenced this issue from a commit 2024-06-29 09:08:50 +00:00

Merge pull request 'add Vale for prose linting' (#1370) from fricklerhandwerk/clan-core:add-vale into main

Sign in to join this conversation.

Reviewers

No reviewers

Qubasa

hsjobeki

Labels

Clear labels   

backups

  

blog

  

bootstrapping

Issues regarding bootstrapping, or onboarding

  

bug

Something is not working.

  

changes-requested

Please fix this.

  

cli

  

documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

facts

Issues regarding facts and secrets setting and generation

  

help wanted

Need some help

  

invalid

Something is wrong

  

Inventory

Inventory

  

low_prio

  

manager

  

modules

  

needs-review

This PR needs to be reviewed. Use the request-changes label to request changes

  

networking

  

packaging

  

question

More information is needed

  

secrets

  

template

Issues regarding templates.

  

test

Issues regarding testing

  

tooling

Issues regarding internal devtools

  

user-testing

Issues that cristallised after hands on user testing.

  

vm

Issues regarding virtual machines.

  

wontfix

This won't be fixed

No Label

backups

blog

bootstrapping

bug

changes-requested

cli

documentation

duplicate

enhancement

facts

help wanted

invalid

Inventory

low_prio

manager

modules

needs-review

networking

packaging

question

secrets

template

test

tooling

user-testing

vm

wontfix

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

4 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: clan/clan-core#1370

No description provided.