clan/clan-core
11
2
Fork 13
Code Issues 91 Pull Requests 5 Actions Packages Projects 1 Releases Wiki Activity

clan: remove very obvious comments #1586

Merged
kenji merged 1 commits from kenji/clan-core:clan/package/clean into main 2024-06-07 13:20:23 +00:00
Conversation 0 Commits 1 Files Changed 1 +2 -14
kenji commented 2024-06-07 12:45:16 +00:00
Owner
Copy Link

Remove some very obvious comments as to not lose meaning of the
comments.

We want comments that convey non-obvious behavior so they will be
actually read.

Remove some very obvious comments as to not lose meaning of the comments. We want comments that convey non-obvious behavior so they will be actually read.
kenji added 1 commit 2024-06-07 12:45:16 +00:00
clan: remove very obvious comments
All checks were successful
checks / checks-impure (pull_request) Successful in 2m54s
Details
buildbot/nix-eval Build done.
Details
4fb4a7f32e 
Remove some very obvious comments as to not lose meaning of the
comments.

We don't want comments that convey non-obvious behavior so they will be
actually read.
kenji force-pushed clan/package/clean from 4fb4a7f32e to 2ce704dd40 2024-06-07 12:46:03 +00:00 Compare
kenji merged commit 4e841d3087 into main 2024-06-07 13:20:23 +00:00
kenji deleted branch clan/package/clean 2024-06-07 13:20:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backups

   
blog

   
bootstrapping

Issues regarding bootstrapping, or onboarding

  
bug

Something is not working.

  
changes-requested

Please fix this.

  
cli

   
documentation

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
facts

Issues regarding facts and secrets setting and generation

  
help wanted

Need some help

  
invalid

Something is wrong

  
Inventory

Inventory

  
low_prio

   
manager

   
modules

   
needs-review

This PR needs to be reviewed. Use the request-changes label to request changes

  
networking

   
packaging

   
question

More information is needed

  
secrets

   
template

Issues regarding templates.

  
test

Issues regarding testing

  
tooling

Issues regarding internal devtools

  
user-testing

Issues that cristallised after hands on user testing.

  
vm

Issues regarding virtual machines.

  
wontfix

This won't be fixed

No Label
backups
blog
bootstrapping
bug
changes-requested
cli
documentation
duplicate
enhancement
facts
help wanted
invalid
Inventory
low_prio
manager
modules
needs-review
networking
packaging
question
secrets
template
test
tooling
user-testing
vm
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: clan/clan-core#1586
No description provided.
Delete Branch "kenji/clan-core:clan/package/clean"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?