fix: outside of direnv clan-li warns show-config deprecated #1619

Merged

kenji merged 3 commits from samrose/clan-core:sam/show-config into main 2024-06-14 08:10:30 +00:00

Conversation 4 Commits 3 Files Changed 1 +2 -2

samrose commented 2024-06-13 16:49:26 +00:00

Contributor

Copy Link

When running nix profile installed clan-cli outside of direnv, there is a warning that show-config will be deprecated

When running nix profile installed clan-cli outside of direnv, there is a warning that `show-config` will be deprecated

samrose added 1 commit 2024-06-13 16:49:26 +00:00

fix: outside of direnv clan-li warns this is going to be deprecated 56a4caf39b

samrose changed title from fix: outside of direnv clan-li warns this is going to be deprecated to fix: outside of direnv clan-li warns show-config deprecated 2024-06-13 16:53:28 +00:00

lassulus commented 2024-06-13 16:55:31 +00:00

Owner

Copy Link

hmm, CI shows:
error: 'config show' is not a recognised command

hmm, CI shows: `error: 'config show' is not a recognised command`

👀 1

samrose commented 2024-06-13 16:58:48 +00:00

Author

Contributor

Copy Link

@lassulus maybe I need to separate them like "config","show"

I'll try that out and push changes that work

@lassulus maybe I need to separate them like `"config","show"` I'll try that out and push changes that work

samrose added 1 commit 2024-06-13 16:59:57 +00:00

fix: formatting cli command correctly 5f22493361

kenji commented 2024-06-13 21:47:27 +00:00

Owner

Copy Link

This doesn't work with the default nix, that nixpkgs ships with.

 $ nix run n#nix -- --version [$-> nix (Nix) 2.18.2]
 $ nix run n#nix config show

The nix_config() function should probably use run_no_stdout, instead of run.

This doesn't work with the default `nix`, that `nixpkgs` ships with. ```shellSession $ nix run n#nix -- --version [$-> nix (Nix) 2.18.2] $ nix run n#nix config show ``` The `nix_config()` function should probably use `run_no_stdout`, instead of `run`.

samrose added 1 commit 2024-06-13 22:45:42 +00:00

fix: trying run_no_stdout with original show-config 06bbae6d14

samrose commented 2024-06-13 22:46:23 +00:00

Author

Contributor

Copy Link

@kenji thank you

I reverted to show-config and added run_no_stdout per your suggestion

@kenji thank you I reverted to `show-config` and added `run_no_stdout` per your suggestion

👍 1

kenji approved these changes 2024-06-14 08:10:22 +00:00

kenji left a comment

Owner

Copy Link

LGTM, thank you @samrose 👍

LGTM, thank you @samrose 👍

kenji merged commit 3d77e0a3a9 into main 2024-06-14 08:10:30 +00:00

kenji referenced this issue from a commit 2024-06-14 08:10:30 +00:00

Merge pull request 'fix: outside of direnv clan-li warns show-config deprecated' (#1619) from samrose/clan-core:sam/show-config into main

Sign in to join this conversation.

Reviewers

No reviewers

kenji

Labels

Clear labels   

backups

  

blog

  

bootstrapping

Issues regarding bootstrapping, or onboarding

  

bug

Something is not working.

  

changes-requested

Please fix this.

  

cli

  

documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

facts

Issues regarding facts and secrets setting and generation

  

help wanted

Need some help

  

invalid

Something is wrong

  

Inventory

Inventory

  

low_prio

  

manager

  

modules

  

needs-review

This PR needs to be reviewed. Use the request-changes label to request changes

  

networking

  

packaging

  

question

More information is needed

  

secrets

  

template

Issues regarding templates.

  

test

Issues regarding testing

  

tooling

Issues regarding internal devtools

  

user-testing

Issues that cristallised after hands on user testing.

  

vm

Issues regarding virtual machines.

  

wontfix

This won't be fixed

No Label

backups

blog

bootstrapping

bug

changes-requested

cli

documentation

duplicate

enhancement

facts

help wanted

invalid

Inventory

low_prio

manager

modules

needs-review

networking

packaging

question

secrets

template

test

tooling

user-testing

vm

wontfix

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: clan/clan-core#1619

No description provided.