clan/clan-core
11
2
Fork 13
Code Issues 91 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

add module to generate zerotier configuration #22

Merged
Mic92 merged 6 commits from zerotier into main 2023-07-25 17:14:27 +00:00
Conversation 0 Commits 6 Files Changed 7 +199 -26
Mic92 commented 2023-07-25 11:49:19 +00:00
Owner
Copy Link
No description provided.
Mic92 reviewed 2023-07-25 11:51:02 +00:00
pkgs/clan-cli/clan_cli/zerotier/__init__.py Outdated
@ -0,0 +90,4 @@
controller_port = find_free_port(range(10000, 65535))
zerotier_exe = shutil.which("zerotier-one")
if zerotier_exe is None:
raise Exception("cannot find zerotier-one executable")
Mic92 commented 2023-07-25 11:51:02 +00:00
Author
Owner
Copy Link

@DavHau I am already not a fan of 100% test coverage. It does not seem practical to setup tests for every error path. It would just result in a slow and harder to maintain test suite that test things that don't matter.

@DavHau I am already not a fan of 100% test coverage. It does not seem practical to setup tests for every error path. It would just result in a slow and harder to maintain test suite that test things that don't matter.
DavHau commented 2023-07-25 13:59:22 +00:00
Owner
Copy Link

OK, my intention was not to enforce actual 100% coverage. More like making it an explicit decision to not cover something, by having to put a pragma: no cover comment somewhere.

We can remove the coverage enforcement, but then the coverage will most likely converge towards 0%, don't you think so?

OK, my intention was not to enforce actual 100% coverage. More like making it an explicit decision to not cover something, by having to put a `pragma: no cover` comment somewhere. We can remove the coverage enforcement, but then the coverage will most likely converge towards 0%, don't you think so?
DavHau commented 2023-07-25 14:00:49 +00:00
Owner
Copy Link

Via #21 I also now added the html coverage output by default.
If you keep your browser open, then it should be simple to find the lines to exclude quickly.

Via https://git.clan.lol/clan/clan-core/pulls/21 I also now added the html coverage output by default. If you keep your browser open, then it should be simple to find the lines to exclude quickly.
Mic92 marked this conversation as resolved
Mic92 force-pushed zerotier from 9ca0f585d4 to 27d376fe1f 2023-07-25 11:54:21 +00:00 Compare
Mic92 force-pushed zerotier from 27d376fe1f to 8ae99ac9d7 2023-07-25 12:08:21 +00:00 Compare
Mic92 force-pushed zerotier from 8ae99ac9d7 to 5ec203681f 2023-07-25 12:08:52 +00:00 Compare
lassulus reviewed 2023-07-25 14:22:11 +00:00
pkgs/clan-cli/clan_cli/zerotier/__init__.py Outdated
@ -0,0 +86,4 @@
# This check could be racy but it's unlikely in practice
controller_port = find_free_port(range(10000, 65535))
zerotier_exe = shutil.which("zerotier-one")
if zerotier_exe is None:
lassulus commented 2023-07-25 14:22:11 +00:00
Owner
Copy Link

why not use nix shell here? we did that in the clan ssh command, and it seems like a cool way

why not use nix shell here? we did that in the clan ssh command, and it seems like a cool way
Mic92 commented 2023-07-25 16:13:54 +00:00
Author
Owner
Copy Link

Would this not quite hard to test in a nix-build?

Would this not quite hard to test in a nix-build?
lassulus commented 2023-07-25 16:19:46 +00:00
Owner
Copy Link

We can build a python function which would check if its installed (then we can supply the packages in a test) or get it when it's not there?

We can build a python function which would check if its installed (then we can supply the packages in a test) or get it when it's not there?
Mic92 commented 2023-07-25 16:21:15 +00:00
Author
Owner
Copy Link

Problem is though that we might get a binary that is not build with nix and that behaves differently. How would you check that we only get the binary that we provided ourself? Someone could for example do nix-shell -p bubblewrap and than run our tool.

Problem is though that we might get a binary that is not build with nix and that behaves differently. How would you check that we only get the binary that we provided ourself? Someone could for example do nix-shell -p bubblewrap and than run our tool.
lassulus commented 2023-07-25 16:24:11 +00:00
Owner
Copy Link

But that is fine and we get a fast cli

But that is fine and we get a fast cli
lassulus commented 2023-07-25 16:28:56 +00:00
Owner
Copy Link

Also the python function can check if the file begins with /nix/store

Also the python function can check if the file begins with /nix/store
Mic92 commented 2023-07-25 16:57:55 +00:00
Author
Owner
Copy Link

done.

done.
Mic92 marked this conversation as resolved
lassulus reviewed 2023-07-25 14:22:55 +00:00
pkgs/clan-cli/clan_cli/zerotier/__init__.py Outdated
@ -0,0 +99,4 @@
home = tempdir / "zerotier-one"
home.mkdir()
cmd = [
"bwrap",
lassulus commented 2023-07-25 14:22:55 +00:00
Owner
Copy Link

same here, I guess we can hardcode some dependencies, but only if we need them in more than 1 codepath?

same here, I guess we can hardcode some dependencies, but only if we need them in more than 1 codepath?
Mic92 marked this conversation as resolved
Mic92 force-pushed zerotier from e1c388136c to 98593fc284 2023-07-25 16:21:57 +00:00 Compare
Mic92 force-pushed zerotier from 98593fc284 to cfd7db6388 2023-07-25 16:23:28 +00:00 Compare
Mic92 force-pushed zerotier from cfd7db6388 to 729a2837e7 2023-07-25 16:57:48 +00:00 Compare
Mic92 force-pushed zerotier from 4215a28dd2 to b9c2a131bc 2023-07-25 17:07:51 +00:00 Compare
Mic92 force-pushed zerotier from b9c2a131bc to 821ff71e4a 2023-07-25 17:13:28 +00:00 Compare
Mic92 merged commit 817a2f9196 into main 2023-07-25 17:14:27 +00:00
Mic92 deleted branch zerotier 2023-07-25 17:15:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backups

   
blog

   
bootstrapping

Issues regarding bootstrapping, or onboarding

  
bug

Something is not working.

  
changes-requested

Please fix this.

  
cli

   
documentation

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
facts

Issues regarding facts and secrets setting and generation

  
help wanted

Need some help

  
invalid

Something is wrong

  
Inventory

Inventory

  
low_prio

   
manager

   
modules

   
needs-review

This PR needs to be reviewed. Use the request-changes label to request changes

  
networking

   
packaging

   
question

More information is needed

  
secrets

   
template

Issues regarding templates.

  
test

Issues regarding testing

  
tooling

Issues regarding internal devtools

  
user-testing

Issues that cristallised after hands on user testing.

  
vm

Issues regarding virtual machines.

  
wontfix

This won't be fixed

No Label
backups
blog
bootstrapping
bug
changes-requested
cli
documentation
duplicate
enhancement
facts
help wanted
invalid
Inventory
low_prio
manager
modules
needs-review
networking
packaging
question
secrets
template
test
tooling
user-testing
vm
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: clan/clan-core#22
No description provided.
Delete Branch "zerotier"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?