clan join: test create vm for clan join #418

DavHau · 2023-10-06T16:53:11Z

DavHau commented

2023-10-06 16:53:11 +00:00

This adds a vm create test for the clan join scenario where:

there is no local clan to write changes to
a machine from a remote flake needs to be built and run
no users and no secrets need to be or can be managed (no flake to write files to)

Also refactor pytest code so that tests can compose their flake individually with the machines they need.
Too much data sharing between tests is not good as manipulating the data for one test introduces breakages elsewhere. It also makes it hard to see what an individual test actually needs because the flake contains lots of things only needed by other tests.

This adds a vm create test for the `clan join` scenario where: - there is no local clan to write changes to - a machine from a remote flake needs to be built and run - no users and no secrets need to be or can be managed (no flake to write files to) Also refactor pytest code so that tests can compose their flake individually with the machines they need. Too much data sharing between tests is not good as manipulating the data for one test introduces breakages elsewhere. It also makes it hard to see what an individual test actually needs because the flake contains lots of things only needed by other tests.

clan-bot was assigned by DavHau

2023-10-06 16:53:11 +00:00

DavHau force-pushed DavHau-dave from 316c6a970d to ceb6bdd474

2023-10-06 17:15:33 +00:00

Compare

clan-bot merged commit af1b8f68e7 into main

2023-10-06 17:17:16 +00:00

clan-bot referenced this issue from a commit

2023-10-06 17:17:16 +00:00

Merge pull request 'clan join: test create vm for clan join' (#418) from DavHau-dave into main

Sign in to join this conversation.

No reviewers