clan/clan-core
12
4
Fork 18
Code Issues 99 Pull Requests 3 Actions Packages Projects 1 Releases Wiki Activity

clan-cli secrets: flake_name -> flake_dir #450

Merged
clan-bot merged 1 commits from flakes into main 2023-11-05 16:27:13 +00:00
Conversation 0 Commits 1 Files Changed 25 +584 -399
lassulus commented 2023-11-03 11:53:01 +00:00
Owner
Copy Link
No description provided.
lassulus force-pushed flakes from b161f7b536 to d306c6d26c 2023-11-03 12:26:31 +00:00 Compare
lassulus force-pushed flakes from d306c6d26c to 71a00c1294 2023-11-03 17:26:15 +00:00 Compare
lassulus force-pushed flakes from 71a00c1294 to 7486bb5b5a 2023-11-04 22:20:57 +00:00 Compare
lassulus force-pushed flakes from 7486bb5b5a to 92acd52518 2023-11-05 00:07:44 +00:00 Compare
lassulus force-pushed flakes from 92acd52518 to 8dc9d21422 2023-11-05 00:13:35 +00:00 Compare
lassulus force-pushed flakes from 8dc9d21422 to 96e073e7d2 2023-11-05 00:39:35 +00:00 Compare
lassulus force-pushed flakes from 96e073e7d2 to 48fed09c62 2023-11-05 10:44:00 +00:00 Compare
lassulus force-pushed flakes from 48fed09c62 to 7b3d3e20b4 2023-11-05 15:59:21 +00:00 Compare
lassulus changed title from WIP: fix flakes to fix flakes 2023-11-05 15:59:28 +00:00
lassulus changed title from fix flakes to clan-cli secrets: flake_name -> flake_dir 2023-11-05 15:59:46 +00:00
Qubasa reviewed 2023-11-05 16:11:18 +00:00
pkgs/clan-cli/clan_cli/__init__.py
@ -53,6 +54,12 @@ def create_parser(prog: Optional[str] = None) -> argparse.ArgumentParser:
default=[],
)
parser.add_argument(
Qubasa commented 2023-11-05 16:11:18 +00:00
Owner
Copy Link

A global flag would be nice, argparse can do that with parent parse feature: https://stackoverflow.com/questions/23296695/permit-argparse-global-flags-after-subcommand

A global flag would be nice, argparse can do that with parent parse feature: https://stackoverflow.com/questions/23296695/permit-argparse-global-flags-after-subcommand
lassulus reviewed 2023-11-05 16:21:22 +00:00
pkgs/clan-cli/clan_cli/secrets/upload.py
@ -39,3 +38,3 @@
def upload_command(args: argparse.Namespace) -> None:
machine = Machine(name=args.machine, flake_dir=specific_flake_dir(args.flake))
machine = Machine(name=args.machine, flake_dir=args.flake)
lassulus commented 2023-11-05 16:21:22 +00:00
Author
Owner
Copy Link

weird, args.flake is a string but flake_dir is defined as a path

weird, args.flake is a string but flake_dir is defined as a path
clan-bot was assigned by lassulus 2023-11-05 16:27:07 +00:00
clan-bot merged commit c47e59d32d into main 2023-11-05 16:27:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backups

   
blog

   
bootstrapping

Issues regarding bootstrapping, or onboarding

  
bug

Something is not working.

  
changes-requested

Please fix this.

  
cli

   
documentation

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
facts

Issues regarding facts and secrets setting and generation

  
help wanted

Need some help

  
invalid

Something is wrong

  
Inventory

Inventory

  
low_prio

   
manager

   
modules

   
needs-review

This PR needs to be reviewed. Use the request-changes label to request changes

  
networking

   
packaging

   
question

More information is needed

  
secrets

   
template

Issues regarding templates.

  
test

Issues regarding testing

  
tooling

Issues regarding internal devtools

  
user-testing

Issues that cristallised after hands on user testing.

  
vm

Issues regarding virtual machines.

  
wontfix

This won't be fixed

No Label
backups
blog
bootstrapping
bug
changes-requested
cli
documentation
duplicate
enhancement
facts
help wanted
invalid
Inventory
low_prio
manager
modules
needs-review
networking
packaging
question
secrets
template
test
tooling
user-testing
vm
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
clan-bot
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: clan/clan-core#450
No description provided.
Delete Branch "flakes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?