POST Create Machine fail because sideEffects with Git Commit #471
Labels
No Label
backups
blog
bootstrapping
bug
changes-requested
cli
documentation
duplicate
enhancement
facts
help wanted
invalid
Inventory
low_prio
manager
modules
needs-review
networking
packaging
question
secrets
template
test
tooling
user-testing
vm
wontfix
No Milestone
No project
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: clan/clan-core#471
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Creating a commit is an advanced feature. We didn't fully discuss yet.
It fails with my git config because i have setup signed commits with gpg.
Somehow it cannot find my gpg public key.
I'd disable / removing advanced git hijacking features until we specify them properly.
I would even put that behind a seperate endpoint but thats a future feature. Right now i cannot create machines anymore, unless i remove the commit feature manually or modify my git config.
@DavHau same applies for PUT /api/{flake}/machines/{name}/config
I cannot change the config of a machine, due to the above reported error
I think the problem arises from having signed commits enabled, which then fails because it doesn't find the signature keys anymore. It would be good to reproduce the issue, but the simples way would be first to disable commits.
We at least have to
git add
changes to the repo, otherwise newly created machines wouldn't appear in the flake outputs and therefore lead to crashes as well.I'm in favor of disabling commits. We now also have git commits in the devShell, which fails as well.
This bug means, i have to disable signed commits to keep working on the project, which is absurd.
We are basically building a CRUD app ontop of nix and json files. Using git gives us the power to work transactional.
We are not using that yet, but might so later.
If we just disable git for now and ignore it might make it harder to add it later.
Maybe you can find out why and fix it?
@hsjobeki Can this be closed?
Api was dropped.