clan/clan-core
12
4
Fork 19
Code Issues 108 Pull Requests 1 Actions Packages Projects 1 Releases Wiki Activity

flake history: make operations atomic #594

Merged
clan-bot merged 1 commits from DavHau-dave into main 2023-12-01 07:03:19 +00:00
Conversation 0 Commits 1 Files Changed 3 +28 -8
DavHau commented 2023-12-01 07:01:34 +00:00
Owner
Copy Link

Prevents potential problems on concurrent requests

Prevents potential problems on concurrent requests
clan-bot was assigned by DavHau 2023-12-01 07:01:34 +00:00
DavHau added 1 commit 2023-12-01 07:01:34 +00:00
flake history: make operations atomic
All checks were successful
checks-impure / test (pull_request) Successful in 1m6s
Details
checks / test (pull_request) Successful in 1m38s
Details
261322fae8
clan-bot merged commit 3a478c4880 into main 2023-12-01 07:03:19 +00:00
DavHau reviewed 2023-12-01 09:12:34 +00:00
pkgs/clan-cli/clan_cli/flakes/add.py
@ -10,4 +11,4 @@
async def add_flake(path: Path) -> dict[str, CmdOut]:
user_history_file().parent.mkdir(parents=True, exist_ok=True)
# append line to history file
# TODO: Make this atomic
DavHau commented 2023-12-01 09:12:29 +00:00
Author
Owner
Copy Link

Ooops, should have removed that line. fixed in: #595

Ooops, should have removed that line. fixed in: https://git.clan.lol/clan/clan-core/pulls/595
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backups

   
blog

   
bootstrapping

Issues regarding bootstrapping, or onboarding

  
bug

Something is not working.

  
changes-requested

Please fix this.

  
cli

   
documentation

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
facts

Issues regarding facts and secrets setting and generation

  
help wanted

Need some help

  
invalid

Something is wrong

  
Inventory

Inventory

  
low_prio

   
manager

   
modules

   
needs-review

This PR needs to be reviewed. Use the request-changes label to request changes

  
networking

   
packaging

   
question

More information is needed

  
secrets

   
template

Issues regarding templates.

  
test

Issues regarding testing

  
tooling

Issues regarding internal devtools

  
user-testing

Issues that cristallised after hands on user testing.

  
vm

Issues regarding virtual machines.

  
wontfix

This won't be fixed

No Label
backups
blog
bootstrapping
bug
changes-requested
cli
documentation
duplicate
enhancement
facts
help wanted
invalid
Inventory
low_prio
manager
modules
needs-review
networking
packaging
question
secrets
template
test
tooling
user-testing
vm
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
clan-bot
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: clan/clan-core#594
No description provided.
Delete Branch "DavHau-dave"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?