clan/clan-core
11
2
Fork 13
Code Issues 91 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

backups: support services for restore #631

Merged
clan-bot merged 2 commits from lassulus-HEAD into main 2023-12-08 18:16:08 +00:00
Conversation 2 Commits 2 Files Changed 6 +158 -91
lassulus commented 2023-12-08 17:49:40 +00:00
Owner
Copy Link

clan-cli Machines: implement eval/build-cache

clan-cli Machines: implement eval/build-cache
Mic92 reviewed 2023-12-08 17:53:27 +00:00
pkgs/clan-cli/clan_cli/backups/list.py Outdated
@ -12,0 +41,4 @@
job_name=parsed_json["job-name"],
)
results.append(backup)
except Exception as e:
Mic92 commented 2023-12-08 17:53:27 +00:00
Owner
Copy Link

json.JSONDecodeError and reduce the try scope size.

json.JSONDecodeError and reduce the try scope size.
Mic92 marked this conversation as resolved
Mic92 reviewed 2023-12-08 17:55:47 +00:00
pkgs/clan-cli/clan_cli/backups/list.py Outdated
@ -12,0 +27,4 @@
)
if proc.returncode != 0:
# TODO this should be a warning, only raise exception if no providers succeed
print(f"failed to list backups for provider {provider}")
Mic92 commented 2023-12-08 17:55:47 +00:00
Owner
Copy Link

raise ClanError

raise ClanError
Mic92 marked this conversation as resolved
lassulus force-pushed lassulus-HEAD from 07996e04d6 to 8340d8f5f2 2023-12-08 18:10:24 +00:00 Compare
Mic92 commented 2023-12-08 18:10:54 +00:00
Owner
Copy Link

Would be great to have a nixos test for this.

Would be great to have a nixos test for this.
lassulus commented 2023-12-08 18:15:47 +00:00
Author
Owner
Copy Link

Would be great to have a nixos test for this.

yes that would be great :)

> Would be great to have a nixos test for this. yes that would be great :)
clan-bot was assigned by lassulus 2023-12-08 18:15:54 +00:00
clan-bot merged commit 28a6613bde into main 2023-12-08 18:16:08 +00:00
Mic92 added the
changes-requested
 label 2023-12-08 19:15:35 +00:00
Mic92 removed the
changes-requested
 label 2023-12-15 11:03:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backups

   
blog

   
bootstrapping

Issues regarding bootstrapping, or onboarding

  
bug

Something is not working.

  
changes-requested

Please fix this.

  
cli

   
documentation

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
facts

Issues regarding facts and secrets setting and generation

  
help wanted

Need some help

  
invalid

Something is wrong

  
Inventory

Inventory

  
low_prio

   
manager

   
modules

   
needs-review

This PR needs to be reviewed. Use the request-changes label to request changes

  
networking

   
packaging

   
question

More information is needed

  
secrets

   
template

Issues regarding templates.

  
test

Issues regarding testing

  
tooling

Issues regarding internal devtools

  
user-testing

Issues that cristallised after hands on user testing.

  
vm

Issues regarding virtual machines.

  
wontfix

This won't be fixed

No Label
backups
blog
bootstrapping
bug
changes-requested
cli
documentation
duplicate
enhancement
facts
help wanted
invalid
Inventory
low_prio
manager
modules
needs-review
networking
packaging
question
secrets
template
test
tooling
user-testing
vm
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
clan-bot
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: clan/clan-core#631
No description provided.
Delete Branch "lassulus-HEAD"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?