clan_vm_manager: Partially working process executor with killpg #656
No reviewers
Labels
No Label
backups
blog
bootstrapping
bug
changes-requested
cli
documentation
duplicate
enhancement
facts
help wanted
invalid
Inventory
low_prio
manager
modules
needs-review
networking
packaging
question
secrets
template
test
tooling
user-testing
vm
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: clan/clan-core#656
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "Qubasa-main"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
merge
Added proc executor
Fully working executor
Improved spawn interface. Added garbage collector
nix fmt
@ -0,0 +137,4 @@
# Create stdin fifo
if in_file.exists():
in_file.unlink()
os.mkfifo(in_file)
Fifos will block writes until there is one consumer:
I wouldn't have them until you have a guaranteed consumer.
@ -0,0 +95,4 @@
print(f"Started new process pid={pid} gpid={gpid}")
# Register the signal handler for SIGINT
signal.signal(signal.SIGTERM, _signal_handler)
Why not stop qemu with in a
try finally
block? Signal handler have the issue that you can only ever have one of them.You also don't need global variables than.
@ -0,0 +85,4 @@
os.setsid()
# Open stdout and stderr
out_fd = os.open(str(out_file), flags=os.O_RDWR | os.O_CREAT | os.O_TRUNC)
This leaks a file descriptor
@ -105,1 +105,4 @@
parser.set_defaults(func=show_overview)
# Define a function that writes to the memfd
memfd?
More fixes in #682