clan/clan-core
12
4
Fork 19
Code Issues 108 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Update start/stop button based on VM state #689

Merged
clan-bot merged 2 commits from Mic92-wayland-update into main 2024-01-04 17:50:25 +00:00
Conversation 0 Commits 2 Files Changed 3 +28 -30
Mic92 commented 2024-01-04 17:43:40 +00:00
Owner
Copy Link
No description provided.
clan-bot was assigned by Mic92 2024-01-04 17:43:40 +00:00
Mic92 added 1 commit 2024-01-04 17:43:40 +00:00
clan-bot was unassigned by Mic92 2024-01-04 17:45:55 +00:00
Mic92 force-pushed Mic92-wayland-update from 5f8ae0f7f5 to b2617ed216 2024-01-04 17:46:14 +00:00 Compare
Mic92 reviewed 2024-01-04 17:47:04 +00:00
pkgs/clan-vm-manager/clan_vm_manager/ui/clan_select_list.py Outdated
@ -193,3 +187,2 @@
self.edit_button.set_sensitive(True)
self.start_button.set_sensitive(True)
self.stop_button.set_sensitive(True)
self.start_button.set_sensitive(vm.status == VMStatus.STOPPED)
Mic92 commented 2024-01-04 17:47:04 +00:00
Author
Owner
Copy Link

This could be potentially now replaced by just one button...

This could be potentially now replaced by just one button...
DavHau commented 2024-01-10 08:51:59 +00:00
Owner
Copy Link

And the button should probably moved into the column that displays the VM.
Also there is still Start/Stop buttons in the context menu (on right click) which don't do anything anymore.

And the button should probably moved into the column that displays the VM. Also there is still Start/Stop buttons in the context menu (on right click) which don't do anything anymore.
Mic92 commented 2024-01-11 11:21:30 +00:00
Author
Owner
Copy Link

I think this will be done after the gtk4 refactor. With this list view it cannot be done.

I think this will be done after the gtk4 refactor. With this list view it cannot be done.
clan-bot was assigned by Mic92 2024-01-04 17:47:20 +00:00
Mic92 force-pushed Mic92-wayland-update from b2617ed216 to c7fda31ab3 2024-01-04 17:48:03 +00:00 Compare
clan-bot merged commit 96e2deee1f into main 2024-01-04 17:50:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backups

   
blog

   
bootstrapping

Issues regarding bootstrapping, or onboarding

  
bug

Something is not working.

  
changes-requested

Please fix this.

  
cli

   
documentation

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
facts

Issues regarding facts and secrets setting and generation

  
help wanted

Need some help

  
invalid

Something is wrong

  
Inventory

Inventory

  
low_prio

   
manager

   
modules

   
needs-review

This PR needs to be reviewed. Use the request-changes label to request changes

  
networking

   
packaging

   
question

More information is needed

  
secrets

   
template

Issues regarding templates.

  
test

Issues regarding testing

  
tooling

Issues regarding internal devtools

  
user-testing

Issues that cristallised after hands on user testing.

  
vm

Issues regarding virtual machines.

  
wontfix

This won't be fixed

No Label
backups
blog
bootstrapping
bug
changes-requested
cli
documentation
duplicate
enhancement
facts
help wanted
invalid
Inventory
low_prio
manager
modules
needs-review
networking
packaging
question
secrets
template
test
tooling
user-testing
vm
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
clan-bot
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: clan/clan-core#689
No description provided.
Delete Branch "Mic92-wayland-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?