clan/clan-core
11
2
Fork 13
Code Issues 90 Pull Requests 4 Actions Packages Projects 1 Releases Wiki Activity

clan_vm_manager: Add GKVStore to combat O(n2) runtimes. Add pygdb to devshell #884

Merged
clan-bot merged 4 commits from Qubasa-main into main 2024-03-01 03:49:53 +00:00
Conversation 0 Commits 4 Files Changed 6 +339 -222
Qubasa commented 2024-02-29 18:59:06 +00:00
Owner
Copy Link

clan_vm_manager: Working GKVStore that emulates the ListStore Object

clan_vm_manager: Fix GLib.idle_add rexecuting the VM push multiple times because of missing GLib.SOURCE_REMOVE

clan_vm_manager: Working GKVStore that emulates the ListStore Object clan_vm_manager: Fix GLib.idle_add rexecuting the VM push multiple times because of missing GLib.SOURCE_REMOVE
clan-bot was assigned by Qubasa 2024-02-29 18:59:06 +00:00
Qubasa added 3 commits 2024-02-29 18:59:06 +00:00
clan_vm_manager: Fix GLib.idle_add rexecuting the VM push multiple times because of missing GLib.SOURCE_REMOVE
Some checks failed
checks / check-links (pull_request) Successful in 23s
Details
checks / checks-impure (pull_request) Successful in 1m56s
Details
checks / checks (pull_request) Failing after 2m22s
Details
5f1191148e
Qubasa added 1 commit 2024-03-01 03:47:20 +00:00
clan_vm_manager: Fix gdb package incompatible with aarch darwin
All checks were successful
checks / check-links (pull_request) Successful in 22s
Details
checks / checks-impure (pull_request) Successful in 1m52s
Details
checks / checks (pull_request) Successful in 2m20s
Details
7932517b4a
clan-bot merged commit 3acc4b4d25 into main 2024-03-01 03:49:53 +00:00
Qubasa requested review from hsjobeki 2024-03-01 03:50:48 +00:00
Qubasa requested review from kenji 2024-03-01 03:50:48 +00:00
kenji approved these changes 2024-03-05 07:59:11 +00:00
kenji left a comment
Owner
Copy Link

Looks good in general.

Looks good in general.
pkgs/clan-vm-manager/clan_vm_manager/models/gkvstore.py
@ -0,0 +138,4 @@
# If the key already exists, remove it O(n)
# TODO: We have to check if updating an existing key is working correctly
if key in self._items:
log.warning("Updating an existing key in GKVStore is O(n)")
kenji commented 2024-03-05 07:57:51 +00:00
Owner
Copy Link

Not sure, if this should be a warning, this is an internal detail?

I think this should probably be debug log output.

Not sure, if this should be a warning, this is an internal detail? I think this should probably be debug log output.
Sign in to join this conversation.
Reviewers
No reviewers
hsjobeki
kenji
Labels
Clear labels   
backups

   
blog

   
bootstrapping

Issues regarding bootstrapping, or onboarding

  
bug

Something is not working.

  
changes-requested

Please fix this.

  
cli

   
documentation

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
facts

Issues regarding facts and secrets setting and generation

  
help wanted

Need some help

  
invalid

Something is wrong

  
Inventory

Inventory

  
low_prio

   
manager

   
modules

   
needs-review

This PR needs to be reviewed. Use the request-changes label to request changes

  
networking

   
packaging

   
question

More information is needed

  
secrets

   
template

Issues regarding templates.

  
test

Issues regarding testing

  
tooling

Issues regarding internal devtools

  
user-testing

Issues that cristallised after hands on user testing.

  
vm

Issues regarding virtual machines.

  
wontfix

This won't be fixed

No Label
backups
blog
bootstrapping
bug
changes-requested
cli
documentation
duplicate
enhancement
facts
help wanted
invalid
Inventory
low_prio
manager
modules
needs-review
networking
packaging
question
secrets
template
test
tooling
user-testing
vm
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
clan-bot
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: clan/clan-core#884
No description provided.
Delete Branch "Qubasa-main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?