clan/clan-core
11
2
Fork 13
Code Issues 91 Pull Requests 5 Actions Packages Projects 1 Releases Wiki Activity

clan-vm-manager: nix fmt fails to find clan-cli python package in ci but it works locally #922

New Issue
Open
opened 2024-03-09 16:55:23 +00:00 by Qubasa · 0 comments
Qubasa commented 2024-03-09 16:55:23 +00:00
Owner
Copy Link
[WARN ] Error using formatter #mypy-pkgs/clan-vm-manager:
    • [STDOUT]:
    clan_vm_manager/components/vmobj.py:15: error: Cannot find implementation or library stub for module named "clan_cli"  [import]
    clan_vm_manager/components/vmobj.py:16: error: Cannot find implementation or library stub for module named "clan_cli.clan_uri"  [import]
    clan_vm_manager/components/vmobj.py:17: error: Cannot find implementation or library stub for module named "clan_cli.history.add"  [import]
    clan_vm_manager/components/vmobj.py:18: error: Cannot find implementation or library stub for module named "clan_cli.machines.machines"  [import]
    clan_vm_manager/singletons/use_vms.py:7: error: Cannot find implementation or library stub for module named "clan_cli.clan_uri"  [import]
    clan_vm_manager/singletons/use_vms.py:8: error: Cannot find implementation or library stub for module named "clan_cli.history.add"  [import]
    clan_vm_manager/singletons/use_join.py:7: error: Cannot find implementation or library stub for module named "clan_cli.clan_uri"  [import]
    clan_vm_manager/singletons/use_join.py:8: error: Cannot find implementation or library stub for module named "clan_cli.history.add"  [import]
    clan_vm_manager/views/list.py:7: error: Cannot find implementation or library stub for module named "clan_cli"  [import]
    clan_vm_manager/views/list.py:8: error: Cannot find implementation or library stub for module named "clan_cli.clan_uri"  [import]
    clan_vm_manager/windows/main_window.py:5: error: Cannot find implementation or library stub for module named "clan_cli.history.list"  [import]
    clan_vm_manager/app.py:12: error: Cannot find implementation or library stub for module named "clan_cli.custom_logger"  [import]
    clan_vm_manager/__init__.py:4: error: Cannot find implementation or library stub for module named "clan_cli.profiler"  [import]
    clan_vm_manager/__init__.py:4: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
    Found 13 errors in 7 files (checked 18 source files)

CI Error: https://git.clan.lol/clan/clan-core/actions/runs/5542/jobs/0#jobstep-2-493

To fix this temporarily I added in pyproject.toml an ignore for clan_cli types:

[[tool.mypy.overrides]]
module = "clan_cli.*"
ignore_missing_imports = true

Added py.typed to root package but treefmt still doesn't work

``` [WARN ] Error using formatter #mypy-pkgs/clan-vm-manager: • [STDOUT]: clan_vm_manager/components/vmobj.py:15: error: Cannot find implementation or library stub for module named "clan_cli" [import] clan_vm_manager/components/vmobj.py:16: error: Cannot find implementation or library stub for module named "clan_cli.clan_uri" [import] clan_vm_manager/components/vmobj.py:17: error: Cannot find implementation or library stub for module named "clan_cli.history.add" [import] clan_vm_manager/components/vmobj.py:18: error: Cannot find implementation or library stub for module named "clan_cli.machines.machines" [import] clan_vm_manager/singletons/use_vms.py:7: error: Cannot find implementation or library stub for module named "clan_cli.clan_uri" [import] clan_vm_manager/singletons/use_vms.py:8: error: Cannot find implementation or library stub for module named "clan_cli.history.add" [import] clan_vm_manager/singletons/use_join.py:7: error: Cannot find implementation or library stub for module named "clan_cli.clan_uri" [import] clan_vm_manager/singletons/use_join.py:8: error: Cannot find implementation or library stub for module named "clan_cli.history.add" [import] clan_vm_manager/views/list.py:7: error: Cannot find implementation or library stub for module named "clan_cli" [import] clan_vm_manager/views/list.py:8: error: Cannot find implementation or library stub for module named "clan_cli.clan_uri" [import] clan_vm_manager/windows/main_window.py:5: error: Cannot find implementation or library stub for module named "clan_cli.history.list" [import] clan_vm_manager/app.py:12: error: Cannot find implementation or library stub for module named "clan_cli.custom_logger" [import] clan_vm_manager/__init__.py:4: error: Cannot find implementation or library stub for module named "clan_cli.profiler" [import] clan_vm_manager/__init__.py:4: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports Found 13 errors in 7 files (checked 18 source files) ``` CI Error: https://git.clan.lol/clan/clan-core/actions/runs/5542/jobs/0#jobstep-2-493 To fix this temporarily I added in [pyproject.toml](https://git.clan.lol/clan/clan-core/src/branch/main/pkgs/clan-vm-manager/pyproject.toml#L29) an ignore for clan_cli types: ```toml [[tool.mypy.overrides]] module = "clan_cli.*" ignore_missing_imports = true ``` Added py.typed to root package but treefmt still doesn't work
Qubasa added the
bug
help wanted
 labels 2024-03-09 16:56:24 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
backups

   
blog

   
bootstrapping

Issues regarding bootstrapping, or onboarding

  
bug

Something is not working.

  
changes-requested

Please fix this.

  
cli

   
documentation

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
facts

Issues regarding facts and secrets setting and generation

  
help wanted

Need some help

  
invalid

Something is wrong

  
Inventory

Inventory

  
low_prio

   
manager

   
modules

   
needs-review

This PR needs to be reviewed. Use the request-changes label to request changes

  
networking

   
packaging

   
question

More information is needed

  
secrets

   
template

Issues regarding templates.

  
test

Issues regarding testing

  
tooling

Issues regarding internal devtools

  
user-testing

Issues that cristallised after hands on user testing.

  
vm

Issues regarding virtual machines.

  
wontfix

This won't be fixed

No Label
backups
blog
bootstrapping
bug
changes-requested
cli
documentation
duplicate
enhancement
facts
help wanted
invalid
Inventory
low_prio
manager
modules
needs-review
networking
packaging
question
secrets
template
test
tooling
user-testing
vm
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: clan/clan-core#922
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?