clan/clan-core
11
2
Fork 13
Code Issues 91 Pull Requests 5 Actions Packages Projects 1 Releases Wiki Activity

clan.static-hosts: excludeHosts should be empty if topLevelDomain is defined. #1538

Merged
kenji merged 1 commits from mrvandalo/clan-core:feature/static-hosts-exclude-nothing-when-tld-is-given into main 2024-06-03 10:44:41 +00:00
Conversation 3 Commits 1 Files Changed 1 +2 -1
mrvandalo commented 2024-06-02 18:59:23 +00:00
Contributor
Copy Link
No description provided.
mrvandalo added 1 commit 2024-06-02 18:59:23 +00:00
clan.static-hosts: excludeHosts should be empty if topLevelDomain is defined.
Some checks failed
buildbot/nix-build .#checks.x86_64-linux.package-impure-checks Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-merge-after-ci Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.nixos-test_install_machine Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-moonlight-sunshine-accept Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-pending-reviews Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-tea-create-pr Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-webview-ui Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-zerotier-members Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-zt-tcp-relay Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.lib-jsonschema-nix-unit-tests Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-zerotierone Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.module-schema Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-function-schema Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.secrets Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-module-schema Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.nixos-flash-installer Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.nixos-iso-installer Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.clan-pytest-with-core Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.wayland-proxy-virtwl Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-iso-installer Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.zt-tcp-relay Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.syncthing Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.treefmt Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-deploy-docs Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-docs Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.test-backups Build done.
Details
checks / checks-impure (pull_request) Successful in 2m17s
Details
buildbot/nix-build .#checks.x86_64-linux.flash Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.test-installation Build done.
Details
buildbot/nix-eval Build done.
Details
c7edc6208c
mrvandalo requested review from kenji 2024-06-02 18:59:50 +00:00
kenji commented 2024-06-02 21:58:24 +00:00
Owner
Copy Link

LGTM, thanks! You should be able to run nix fmt for the failing check.

LGTM, thanks! You should be able to run `nix fmt` for the failing check.
kenji approved these changes 2024-06-02 21:58:47 +00:00
mrvandalo commented 2024-06-03 08:20:33 +00:00
Author
Contributor
Copy Link

Ah right, I just ran nixpkgs-fmt

Ah right, I just ran `nixpkgs-fmt`
mrvandalo force-pushed feature/static-hosts-exclude-nothing-when-tld-is-given from c7edc6208c to e3e7d7e90b 2024-06-03 08:24:26 +00:00 Compare
mrvandalo force-pushed feature/static-hosts-exclude-nothing-when-tld-is-given from e3e7d7e90b to 9033757a74 2024-06-03 08:38:23 +00:00 Compare
mrvandalo force-pushed feature/static-hosts-exclude-nothing-when-tld-is-given from 9033757a74 to 6c4263a900 2024-06-03 08:38:44 +00:00 Compare
kenji commented 2024-06-03 10:44:33 +00:00
Owner
Copy Link

Thank you!

Thank you!
kenji merged commit 259d51bdc8 into main 2024-06-03 10:44:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
kenji
Labels
Clear labels   
backups

   
blog

   
bootstrapping

Issues regarding bootstrapping, or onboarding

  
bug

Something is not working.

  
changes-requested

Please fix this.

  
cli

   
documentation

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
facts

Issues regarding facts and secrets setting and generation

  
help wanted

Need some help

  
invalid

Something is wrong

  
Inventory

Inventory

  
low_prio

   
manager

   
modules

   
needs-review

This PR needs to be reviewed. Use the request-changes label to request changes

  
networking

   
packaging

   
question

More information is needed

  
secrets

   
template

Issues regarding templates.

  
test

Issues regarding testing

  
tooling

Issues regarding internal devtools

  
user-testing

Issues that cristallised after hands on user testing.

  
vm

Issues regarding virtual machines.

  
wontfix

This won't be fixed

No Label
backups
blog
bootstrapping
bug
changes-requested
cli
documentation
duplicate
enhancement
facts
help wanted
invalid
Inventory
low_prio
manager
modules
needs-review
networking
packaging
question
secrets
template
test
tooling
user-testing
vm
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: clan/clan-core#1538
No description provided.
Delete Branch "mrvandalo/clan-core:feature/static-hosts-exclude-nothing-when-tld-is-given"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?