clan-cli: improve runtime dependency management #1733

Merged

clan-bot merged 1 commits from DavHau/clan-core:DavHau-vars into main 2024-07-11 08:38:27 +00:00

Conversation 0 Commits 1 Files Changed 7 +132 -56

DavHau commented 2024-07-11 08:35:05 +00:00

Owner

Copy Link

Many dependencies of clan-cli are currently dynamically loaded via nix-shell on each execution.
This is nice, as it reduces the initial closure size of clan, but the overhead introduced by nix-shell piles up quickly, as some commands shell out many times during their lifetime. For example, when adding a secret git is called 10+ times.

This reduces the time of a test which adds a secret from around 50 seconds to 15 seconds.

• add run_cmd() as an alternative to nix_shell()
• introduce the concept of static dependencies which do not need to go through nix-shell
• static dependencies are defined at build time and included into the wrapper for clan-cli
• add package: clan-cli-full which statically ships all required dependencies

TODO: deprecate nix_shell() in favor of run_cmd()

Many dependencies of clan-cli are currently dynamically loaded via nix-shell on each execution. This is nice, as it reduces the initial closure size of clan, but the overhead introduced by nix-shell piles up quickly, as some commands shell out many times during their lifetime. For example, when adding a secret git is called 10+ times. This reduces the time of a test which adds a secret from around 50 seconds to 15 seconds. - add run_cmd() as an alternative to nix_shell() - introduce the concept of static dependencies which do not need to go through nix-shell - static dependencies are defined at build time and included into the wrapper for clan-cli - add package: clan-cli-full which statically ships all required dependencies TODO: deprecate nix_shell() in favor of run_cmd()

DavHau added the

needs-review

label 2024-07-11 08:35:05 +00:00

clan-bot was assigned by DavHau 2024-07-11 08:35:05 +00:00

lassulus was assigned by DavHau 2024-07-11 08:35:05 +00:00

Mic92 was assigned by DavHau 2024-07-11 08:35:05 +00:00

DavHau added 1 commit 2024-07-11 08:35:06 +00:00

clan-cli: improve runtime dependency management ... 75b969b1ad

Many dependencies of clan-cli  are currently dynamically loaded via nix-shell on each execution.
This is nice, as it reduces the initial closure size of clan, but the overhead introduced by nix-shell piles up quickly, as some commands shell out many times during their lifetime. For example, when adding a secret git is called 10+ times.

This reduces the time of a test which adds a secret from around 50 seconds to 15 seconds.

- add run_cmd() as an alternative to nix_shell()
- introduce the concept of static dependencies which do not need to go through nix-shell
- static dependencies are defined at build time and included into the wrapper for clan-cli
- add package: clan-cli-full which statically ships all required dependencies

TODO: deprecate nix_shell() in favor of run_cmd()

clan-bot merged commit 7055b352d4 into main 2024-07-11 08:38:27 +00:00

clan-bot referenced this issue from a commit 2024-07-11 08:38:29 +00:00

Merge pull request 'clan-cli: improve runtime dependency management' (#1733) from DavHau/clan-core:DavHau-vars into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backups

  

blog

  

bootstrapping

Issues regarding bootstrapping, or onboarding

  

bug

Something is not working.

  

changes-requested

Please fix this.

  

cli

  

documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

facts

Issues regarding facts and secrets setting and generation

  

help wanted

Need some help

  

invalid

Something is wrong

  

Inventory

Inventory

  

low_prio

  

manager

  

modules

  

needs-review

This PR needs to be reviewed. Use the request-changes label to request changes

  

networking

  

packaging

  

question

More information is needed

  

secrets

  

template

Issues regarding templates.

  

test

Issues regarding testing

  

tooling

Issues regarding internal devtools

  

user-testing

Issues that cristallised after hands on user testing.

  

vm

Issues regarding virtual machines.

  

wontfix

This won't be fixed

No Label

backups

blog

bootstrapping

bug

changes-requested

cli

documentation

duplicate

enhancement

facts

help wanted

invalid

Inventory

low_prio

manager

modules

needs-review

networking

packaging

question

secrets

template

test

tooling

user-testing

vm

wontfix

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

clan-bot

lassulus

Mic92

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: clan/clan-core#1733

No description provided.