clan/clan-core
12
4
Fork 19
Code Issues 108 Pull Requests 3 Actions Packages Projects 1 Releases Wiki Activity

state: remove /home from default state folders #1886

Merged
kenji merged 1 commits from kenji/clan-core:remove-home-from-state into main 2024-08-20 10:02:12 +00:00
Conversation 2 Commits 1 Files Changed 2 +2 -2
kenji commented 2024-08-14 13:13:11 +00:00
Owner
Copy Link

Home should not always be set by default.
In the UI we can suggest it, but it catches a lot of state you might not
want to back up.

Home should not always be set by default. In the UI we can suggest it, but it catches a lot of state you might not want to back up.
kenji added the
needs-review
 label 2024-08-14 13:13:11 +00:00
DavHau was assigned by kenji 2024-08-14 13:13:11 +00:00
kenji added 1 commit 2024-08-14 13:13:11 +00:00
state: remove /home from default state folders
All checks were successful
buildbot/nix-build .#checks.x86_64-linux.package-inventory-api-docs Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.container Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-yagna Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-clan-vm-manager Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.lib-jsonschema-example-valid Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.devShell-clan-cli Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-inventory-schema Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-clan-cli Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-clan-ts-api Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-clan-cli-docs Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-inventory-schema-pretty Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-editor Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-default Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.module-schema Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.lib-jsonschema-nix-unit-tests Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-merge-after-ci Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-impure-checks Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-pending-reviews Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-tea-create-pr Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-webview-ui Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-zerotier-members Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-zt-tcp-relay Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-zerotierone Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-moonlight-sunshine-accept Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-function-schema Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-module-schema Build done.
Details
checks / checks-impure (pull_request) Successful in 2m48s
Details
buildbot/nix-build .#checks.x86_64-linux.flash Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.test-installation Build done.
Details
buildbot/nix-eval Build done.
Details
81144162f2 
Home should not always be set by default.
In the UI we can suggest it, but it catches a lot of state you might not
want to back up.
kenji requested review from DavHau 2024-08-14 13:13:17 +00:00
lassulus approved these changes 2024-08-14 15:14:31 +00:00
Mic92 commented 2024-08-14 16:21:22 +00:00
Owner
Copy Link

Do we not also need this to persist /home in virtual machines?

Do we not also need this to persist /home in virtual machines?
kenji force-pushed remove-home-from-state from 81144162f2 to 0e55fd2162 2024-08-20 09:55:41 +00:00 Compare
kenji force-pushed remove-home-from-state from 0e55fd2162 to 268acce59e 2024-08-20 09:56:36 +00:00 Compare
kenji commented 2024-08-20 10:02:05 +00:00
Author
Owner
Copy Link

@Mic92
I moved the default to vm.nix which is the default for vm's.
It should be picked up by the vm that way.

@Mic92 I moved the default to `vm.nix` which is the default for vm's. It should be picked up by the vm that way.
kenji merged commit 9d36262a13 into main 2024-08-20 10:02:12 +00:00
kenji deleted branch remove-home-from-state 2024-08-20 10:02:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
DavHau
lassulus
Labels
Clear labels   
backups

   
blog

   
bootstrapping

Issues regarding bootstrapping, or onboarding

  
bug

Something is not working.

  
changes-requested

Please fix this.

  
cli

   
documentation

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
facts

Issues regarding facts and secrets setting and generation

  
help wanted

Need some help

  
invalid

Something is wrong

  
Inventory

Inventory

  
low_prio

   
manager

   
modules

   
needs-review

This PR needs to be reviewed. Use the request-changes label to request changes

  
networking

   
packaging

   
question

More information is needed

  
secrets

   
template

Issues regarding templates.

  
test

Issues regarding testing

  
tooling

Issues regarding internal devtools

  
user-testing

Issues that cristallised after hands on user testing.

  
vm

Issues regarding virtual machines.

  
wontfix

This won't be fixed

No Label
backups
blog
bootstrapping
bug
changes-requested
cli
documentation
duplicate
enhancement
facts
help wanted
invalid
Inventory
low_prio
manager
modules
needs-review
networking
packaging
question
secrets
template
test
tooling
user-testing
vm
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
DavHau
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: clan/clan-core#1886
No description provided.
Delete Branch "kenji/clan-core:remove-home-from-state"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?