clan/clan-core
12
4
Fork 19
Code Issues 108 Pull Requests 3 Actions Packages Projects 1 Releases Wiki Activity

clanModules: Init nginx module. matrix-synapse: don't assume domain names #1906

Merged
clan-bot merged 3 commits from Qubasa/clan-core:Qubasa-new-main into main 2024-08-19 10:59:16 +00:00
Conversation 1 Commits 3 Files Changed 9 +278 -27
Qubasa commented 2024-08-19 09:34:09 +00:00
Owner
Copy Link

clanModules: Init vaultwarden, the bitwarden server

clanModules: Init vaultwarden, the bitwarden server
clan-bot was assigned by Qubasa 2024-08-19 09:34:09 +00:00
Qubasa added 2 commits 2024-08-19 09:34:10 +00:00
clanModules: Init vaultwarden, the bitwarden server
Some checks failed
buildbot/nix-build .#checks.x86_64-linux.package-inventory-schema Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.container Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-clan-cli Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-inventory-schema-pretty Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-clan-cli-docs Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-clan-ts-api Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.mumble Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-editor Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-default Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.lib-jsonschema-nix-unit-tests Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.nixos-test_install_machine Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-impure-checks Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-merge-after-ci Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-moonlight-sunshine-accept Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.postgresql Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-pending-reviews Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-tea-create-pr Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.template-minimal Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-webview-ui Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-zerotier-members Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-zt-tcp-relay Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.package-zerotierone Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.nixos-flash-installer Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.secrets Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.zt-tcp-relay Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.syncthing Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.wayland-proxy-virtwl Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.flash Build done.
Details
buildbot/nix-eval Build done.
Details
buildbot/nix-build .#checks.x86_64-linux.test-installation Build done.
Details
8326c9d941
Qubasa force-pushed Qubasa-new-main from 8326c9d941 to 398997a98e 2024-08-19 09:41:32 +00:00 Compare
Qubasa force-pushed Qubasa-new-main from 398997a98e to eb5c89db21 2024-08-19 10:00:40 +00:00 Compare
Qubasa force-pushed Qubasa-new-main from eb5c89db21 to c14a0689bc 2024-08-19 10:53:36 +00:00 Compare
clan-bot merged commit b29f649343 into main 2024-08-19 10:59:16 +00:00
lassulus reviewed 2024-08-20 08:45:58 +00:00
clanModules/nginx/default.nix
@ -0,0 +27,4 @@
let
path = config.clan.core.facts.services."${nginx_acme_email}".public."${nginx_acme_email}".path;
in
if builtins.pathExists path then builtins.readFile path else null
lassulus commented 2024-08-20 08:45:58 +00:00
Owner
Copy Link

this breaks with other fact stores than the in_repo one. it's better to use .value here instead of .path

this breaks with other fact stores than the in_repo one. it's better to use .value here instead of .path
lassulus reviewed 2024-08-20 08:47:08 +00:00
clanModules/vaultwarden/default.nix
@ -0,0 +102,4 @@
};
clan.core.facts.services = {
"${admin_pwd_secret}" = {
lassulus commented 2024-08-20 08:47:08 +00:00
Owner
Copy Link

why is this using variables?

why is this using variables?
lassulus reviewed 2024-08-20 08:48:02 +00:00
clanModules/vaultwarden/default.nix
@ -0,0 +135,4 @@
};
};
systemd.services."${module_name}" = {
lassulus commented 2024-08-20 08:48:02 +00:00
Owner
Copy Link

better not use variables in here

better not use variables in here
lassulus reviewed 2024-08-20 08:48:14 +00:00
clanModules/vaultwarden/default.nix
@ -0,0 +141,4 @@
};
};
services."${module_name}" = {
lassulus commented 2024-08-20 08:48:14 +00:00
Owner
Copy Link

better not use variables here

better not use variables here
lassulus reviewed 2024-08-20 08:48:45 +00:00
clanModules/nginx/default.nix
@ -0,0 +66,4 @@
sslDhparam = config.security.dhparams.params.nginx.path;
};
security.dhparams = {
lassulus commented 2024-08-20 08:48:45 +00:00
Owner
Copy Link

what is this needed for?

what is this needed for?
lassulus reviewed 2024-08-20 08:50:05 +00:00
clanModules/matrix-synapse/default.nix
@ -178,3 +179,3 @@
enable = true;
virtualHosts = {
${cfg.domain} = {
"${cfg.domain.server}" = {
lassulus commented 2024-08-20 08:50:05 +00:00
Owner
Copy Link

this is incorrect, the well-known matrix entry needs to be on the root domain (not matrix.something)

this is incorrect, the well-known matrix entry needs to be on the root domain (not matrix.something)
Mic92 commented 2024-08-21 08:15:16 +00:00
Owner
Copy Link

Reverted for now because of the concerns raised here: #1941

Reverted for now because of the concerns raised here: https://git.clan.lol/clan/clan-core/pulls/1941
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backups

   
blog

   
bootstrapping

Issues regarding bootstrapping, or onboarding

  
bug

Something is not working.

  
changes-requested

Please fix this.

  
cli

   
documentation

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
facts

Issues regarding facts and secrets setting and generation

  
help wanted

Need some help

  
invalid

Something is wrong

  
Inventory

Inventory

  
low_prio

   
manager

   
modules

   
needs-review

This PR needs to be reviewed. Use the request-changes label to request changes

  
networking

   
packaging

   
question

More information is needed

  
secrets

   
template

Issues regarding templates.

  
test

Issues regarding testing

  
tooling

Issues regarding internal devtools

  
user-testing

Issues that cristallised after hands on user testing.

  
vm

Issues regarding virtual machines.

  
wontfix

This won't be fixed

No Label
backups
blog
bootstrapping
bug
changes-requested
cli
documentation
duplicate
enhancement
facts
help wanted
invalid
Inventory
low_prio
manager
modules
needs-review
networking
packaging
question
secrets
template
test
tooling
user-testing
vm
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
clan-bot
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: clan/clan-core#1906
No description provided.
Delete Branch "Qubasa/clan-core:Qubasa-new-main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?