clan_cli: create key directory #521

kenji · 2023-11-15T22:31:15Z

kenji commented

2023-11-15 22:31:15 +00:00

Create the secrets key directory, if not already present.

clan-bot was assigned by kenji

2023-11-15 22:31:15 +00:00

kenji added 1 commit 2023-11-15 22:31:15 +00:00

clan_cli: create key directory

checks / test (pull_request) Successful in 1m3s

Details

checks-impure / test (pull_request) Successful in 1m50s

Details

12930b4057

clan-bot was unassigned by lassulus

2023-11-16 11:17:57 +00:00

clan-bot was assigned by lassulus

2023-11-16 11:18:02 +00:00

lassulus merged commit 2f870d2c83 into main

2023-11-16 11:18:33 +00:00

lassulus deleted branch a-kenji-mkdir/clan/cli

2023-11-16 11:18:33 +00:00

lassulus referenced this issue from a commit

2023-11-16 11:18:35 +00:00

Merge pull request 'clan_cli: create key directory' (#521) from a-kenji-mkdir/clan/cli into main

Mic92 reviewed 2023-11-16 12:16:01 +00:00

pkgs/clan-cli/clan_cli/secrets/key.py

						
				@ -10,6 +10,8 @@ def generate_key() -> str:

				    if path.exists():

				        raise ClanError(f"Key already exists at {path}")

				    priv_key, pub_key = generate_private_key()

				    if not (parent := path.parent).exists():

Mic92 commented

2023-11-16 12:16:01 +00:00

That condition is not needed with exist_ok=True

That condition is not needed with `exist_ok=True`

👍 1

Mic92 commented

2023-11-16 12:19:52 +00:00

#522

https://git.clan.lol/clan/clan-core/pulls/522

Mic92 marked this conversation as resolved

Mic92 added the

changes-requested

label 2023-11-16 12:16:12 +00:00

Mic92 removed the

changes-requested

label 2023-11-16 12:20:31 +00:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: clan/clan-core#521